Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"transient" -> "transitive" #187

Merged
merged 1 commit into from
Jul 26, 2016
Merged

"transient" -> "transitive" #187

merged 1 commit into from
Jul 26, 2016

Conversation

amasad
Copy link
Contributor

@amasad amasad commented Jul 25, 2016

No description provided.

@ghost
Copy link

ghost commented Jul 25, 2016

Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email cla@fb.com with your details so we can update your status.

@amasad
Copy link
Contributor Author

amasad commented Jul 25, 2016

Keep getting errors trying to sign the CLA. Maybe because I'm a former employee?

screen shot 2016-07-25 at 12 21 13 pm

@gaearon
Copy link
Contributor

gaearon commented Jul 25, 2016

Let me ask the OS folks. Thanks!

@jamesgpearce
Copy link

Is that what you see when you go to the page? Or when you submit it?

@amasad
Copy link
Contributor Author

amasad commented Jul 25, 2016

When I submit it

On Mon, Jul 25, 2016, 1:26 PM James Pearce notifications@github.com wrote:

Is that what you see when you go to the page? Or when you submit it?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#187 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAj2_iyUxFfxq_oNhV_pK0HyJOIT_dhbks5qZRvYgaJpZM4JUdHj
.

@ghost ghost added the CLA Signed label Jul 26, 2016
@ghost
Copy link

ghost commented Jul 26, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sophiebits sophiebits merged commit 3e9fb85 into facebook:master Jul 26, 2016
@sophiebits
Copy link
Contributor

Thanks!

@gaearon
Copy link
Contributor

gaearon commented Jul 26, 2016

😳

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants