Add support for SVG tspan and image elements, and the preserveAspectRatio attribute #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -161,7 +164,9 @@ var DefaultDOMPropertyConfig = { | |||
| stopOpacity: 'stop-opacity', | |||
| strokeLinecap: 'stroke-linecap', | |||
| strokeWidth: 'stroke-width', | |||
| viewBox: 'viewBox' | |||
| viewBox: 'viewBox', | |||
| xlinkNamespace: 'xmlns:xlink', | |||
There was a problem hiding this comment.
why not xmlnsXlink? xlinkNamespace seems like a weird name
There was a problem hiding this comment.
Happy to change it to xmlnsXlink if that's better.
ghost
assigned 
| @@ -79,6 +80,7 @@ var markupWrap = { | |||
| 'circle': svgWrap, | |||
| 'defs': svgWrap, | |||
| 'g': svgWrap, | |||
| 'image': svgWrap, | |||
There was a problem hiding this comment.
Should image be also in shouldWrap with other svg elements?
|
Closing this pull request because it's superseded by this patch: #938 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds this support and updates the documentation.