Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more SVG tags to dom.clj #150

Closed
osnr opened this issue Mar 26, 2014 · 4 comments
Closed

add more SVG tags to dom.clj #150

osnr opened this issue Mar 26, 2014 · 4 comments

Comments

@osnr
Copy link

osnr commented Mar 26, 2014

React 0.9 added some new tags:

Added support for SVG tags defs, linearGradient, polygon, radialGradient, stop

http://facebook.github.io/react/blog/2014/02/20/react-v0.9.html

Would be great to get support for these so we can add marker arrows, etc.

@osnr
Copy link
Author

osnr commented Mar 26, 2014

(turns out this isn't especially useful [for me] because React itself doesn't support marker and some other tags)

@piranha
Copy link

piranha commented Mar 26, 2014

Contributing those to React shouldn't be hard if you need them. :)

@osnr
Copy link
Author

osnr commented Mar 26, 2014

You'd be surprised; there are still a few standing pull requests to add SVG tags:
facebook/react#868
facebook/react#938 (this one has the tags I need, but it's huge)
facebook/react#1032

This smaller one was actually closed in favor of 938, which seems like a mess to wade into: facebook/react#830

But this is off-topic, anyway. Still would be good to add these tags to Om that are already supported in React 0.9.

@swannodette
Copy link
Member

fixed 264418b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants