Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial CircleCI -> GitHub Actions migration #12163

Closed
wants to merge 11 commits into from
Closed

Initial CircleCI -> GitHub Actions migration #12163

wants to merge 11 commits into from

Conversation

pdillinger
Copy link
Contributor

@pdillinger pdillinger commented Dec 19, 2023 •
edited
Loading

Summary:

  • Largely based on GitHub actions and workflows #12085 but grouped into one large workflow because of bad GHA UI design (see comments).
  • Windows job details consolidated into an action file so that those jobs can easily move between per-pr-push and nightly.
  • Simplify some handling of "CIRCLECI" environment and add "GITHUB_ACTIONS" in the same places
  • For jobs that we want to go in pr-jobs or nightly there are disabled "candidate" workflows with draft versions of those jobs.
  • ARM jobs are disabled waiting on full GHA support.
  • build-linux-java-static needed some special attention to work, due to GLIBC compatibility issues (see comments).

Test Plan:
Nightly jobs can be seen passing between these two links:
https://github.com/facebook/rocksdb/actions/runs/7266835435/job/19799390061?pr=12163
https://github.com/facebook/rocksdb/actions/runs/7269697823/job/19807724471?pr=12163

And per-PR jobs of course passing on this PR.

@pdillinger
Initial, partial CircleCI -> GitHub Actions migration
f8893f2 
Summary: Largely based on facebook#12085 but grouped into one large workflow
because of bad GHA UI design (see comments).

Test Plan: TODO
@pdillinger pdillinger marked this pull request as ready for review December 20, 2023 17:49
@facebook-github-bot
Copy link
Contributor

@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pdillinger has updated the pull request. You must reimport the pull request before landing.

@pdillinger pdillinger changed the title Initial, partial CircleCI -> GitHub Actions migration Initial CircleCI -> GitHub Actions migration Dec 21, 2023
@facebook-github-bot
Copy link
Contributor

@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pdillinger
Copy link
Contributor Author

build-linux-static_lib-alt_namespace-status_checked was broken in main by #12159

@facebook-github-bot
Copy link
Contributor

@pdillinger merged this pull request in 106058c.

This was referenced Dec 21, 2023
Closed
Closed
@adamretter
Copy link
Collaborator

@pdillinger What is the plan for migrating the Continuous Benchmarks that use a custom CircleCI runner in an RocksDB Team owned EC2 instance?

@adamretter
Copy link
Collaborator

@pdillinger Still would like to hear about:

What is the plan for migrating the Continuous Benchmarks that use a custom CircleCI runner in an RocksDB Team owned EC2 instance?

@jaykorean jaykorean mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hx235 hx235 hx235 approved these changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdillinger @facebook-github-bot @adamretter @hx235