Use the correct Docker Image for RocksJava on Linux #12169
Conversation
adamretter
force-pushed
the
correct-docker-image
branch
4 times, most recently
from
31851e8
to
ebbc054
Compare
|
Sorry but now the changes will have to go to the GitHub Actions config. (After merge/rebase with #12163 ) Thanks for hacking on the docker image! |
adamretter
force-pushed
the
correct-docker-image
branch
10 times, most recently
from
42419d8
to
0ca0338
Compare
…t has glibc 2.28; glibc >= 2.27 is needed for GitHub Actions Upload Artifact step
adamretter
force-pushed
the
correct-docker-image
branch
from
0ca0338
to
97b62f9
Compare
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pdillinger I have updated this for GitHub Actions now. There are two Folly build failures, I am not certain, but I think they are unrelated to my changes, can you confirm? |
| - name: Checkout | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| run: | |
There was a problem hiding this comment.
This is copy-pasting a complex piece of functionality. Presumably it can go into a sharable "uses" step.
There was a problem hiding this comment.
@pdillinger I did try that, but unfortunately it is not possible as you end up in a "chicken or egg" situation. i.e. if you put the code in a separate GitHub action file of this repo, then it isn't yet available as the code hasn't been checked out from Git until after this step would run.
No description provided.