This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Add Node.js version 10 for CI #1909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
|
I updated |
|
Thanks for contributing a fix for the Gulp crash on Node 10, @noelyoo! I'd prefer to upgrade May I ask you to please use Yarn's selective dependency version resolution instead of editing the lockfile directly? I tested this addition to package.json and it works: |
claudiopro
suggested changes
Oct 21, 2018
claudiopro
approved these changes
Oct 22, 2018
There was a problem hiding this comment.
claudiopro is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@claudiopro I’m happy to contribute 👍 |
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** This PR adds nodejs version `10` for the Travis Ci build Details: * https://github.com/nodejs/Release#end-of-life-releases * https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#specifying-nodejs-versions  **Test Plan** Travis CI test Pull Request resolved: facebookarchive#1909 Differential Revision: D10487838 fbshipit-source-id: 98d98ea38da66752c6c73fd379acb024058f09a3
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** This PR adds nodejs version `10` for the Travis Ci build Details: * https://github.com/nodejs/Release#end-of-life-releases * https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#specifying-nodejs-versions  **Test Plan** Travis CI test Pull Request resolved: facebookarchive/draft-js#1909 Differential Revision: D10487838 fbshipit-source-id: 98d98ea38da66752c6c73fd379acb024058f09a3
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** This PR adds nodejs version `10` for the Travis Ci build Details: * https://github.com/nodejs/Release#end-of-life-releases * https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#specifying-nodejs-versions  **Test Plan** Travis CI test Pull Request resolved: facebookarchive/draft-js#1909 Differential Revision: D10487838 fbshipit-source-id: 98d98ea38da66752c6c73fd379acb024058f09a3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds nodejs version
10for the Travis Ci buildDetails:
Test Plan
Travis CI test