-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native crash in Node 10 #2162
Comments
I tried the following configurations (using Linux):
I am unable to reproduce your issue (see last line). The only difference is that I am using Linux instead of Mac or Windows. Could you try to use Gulp 4.0.0 on your system and report if the error still happens? It would at least provide a mitigation for the issue. The next step would be to locate the line actually causing the error: the Node dump is not very helpful unfortunately. |
@demurgos you should probably see nodejs/node#19786 and #2146 as these are related to this issue. |
@roblourens Did you run |
Yes I tried those things. From the other issues, sounds like I'm not the only one seeing this. |
@roblourens You're the only one who has reported this issue so far - those other issues linked were historical, and we resolved the issues in those prior to the release. |
I'm facing the same issue using Windows 10 and Node 10.
|
I was unable to reproduce on macos with node 10 using @demurgos example. |
I'm having this same issue. You can see the Travis CI Output and the GitHub Repo. |
@fishcharlie @roblourens @MichaReiser nothing is going to be done on our side. Maybe you should bring this up with the node folks. |
Actually I can't repro with @demurgos' example. I can still repro with other projects, using the same gulp version, so I'm guessing the difference is some other dep in the package-lock.json. But this reproes even after |
@phated It says a fix is in Gulp v4. I see a tag on GitHub for version 4, but it doesn't look to be released on NPM. Any updates on that front? |
Also using node from nvm vs normal binary makes no difference |
@roblourens there's a patch version of @fishcharlie news to me: |
@phated My bad. I was relying on the NPM detail page. I'm assuming that page just displays the |
@fishcharlie yeah, never rely on that page. It's terrible - always use |
I stopped understanding how npm works at some point, I don't know why I wasn't already getting the latest, but yeah forcing |
Hooray another lockfile failure! So frustrating. An aside: @roblourens would you be able to DM me on twitter (https://twitter.com/BlaineBublitz) - I'm interested to chat about VS Code + gulp |
Just another note that we've started experiencing this on a daily Travis cron, using Gulp 3.9.1, that had been working fine until yesterday - with no changes for months. Given that Gulp 4 isn't ready for prime time yet, it would be nice to see a fix backported to Gulp 3. I'm not sure exactly what's involved but it's possible it's just a dependency update. But I am assuming the best solution for now is just not to use Node 10! |
@tdmalone I think you didn't read the whole thread, which includes the change. It's due to your lock file. |
@phated Got it - thank you! I did indeed get confused. For others coming across this, here's what you need to do for Node 10 support (if using Yarn):
If using npm with a package-lock.json the process will probably be fairly similar. (Be careful modifying your lock file. There's probably a better way to do it!) |
Same issue with the console output.
Solution is delete node_modules dir and package-lock.json. |
If you are using yarn you can try the following: Use |
@Carlos7646 this solution worked me too, thanks man! |
Same error for:
Solution: rm -rf node_modules
rm -rf package-lock.json
npm cache clean
npm install See @Carlos7646 and Alberto answers for details. Thanks. |
I wouldn't recommend deleting your entire lock file, unless you're sure that you want to upgrade everything. It's probably better just to upgrade the exact package that is causing the issue (which is |
You can also add this to your package.json:
clearest workaround so far. worked for me (win10, node10) |
**Summary** These are a few upgrades of dependencies in order to address issues on node 10 (in relation to: #5477) *duplexify* *3.5.0* => *3.5.4* (mafintosh/duplexify@00d08fa) *v8-compile-cache* *^1.1.0* => *^2.0.0* (zertosh/v8-compile-cache#7) *natives* *1.1.0* => *1.1.3* (gulpjs/gulp#2162) The last did not have to do with `new Buffer` but was something I personally encountered when using `gulp` for building in `node 10`. I don't know how common this is, but the fix is easy and within scope, so decided to include it. **Test plan** CI should be green.
It seems we need gulp 4 for it gulpjs/gulp#2162
See [this gulp issue](gulpjs/gulp#2162)
[Build was breaking](https://travis-ci.org/eventbrite/eventbrite-sdk-javascript/builds/374217527) on `'node'` version in Travis because `'node'` now points to new v10 that that was released. One of gulp's dependencies didn't work correctly with it. See: gulpjs/gulp#2162 (comment). The fix was to `yarn remove gulp gulp-debug` and `yarn add --dev gulp gulp-debug`. This bumped `gulp-debug` to a new version, but the main fix was the updates to `yarn.lock` to use new versions of packages specifically `natives@1.1.13`.
I was experiencing this issue as well with gulp v3.9.1. Switching to Node v9.0 solved it for me. |
@kneeki Node 9 is about to go into maintenance so that'll only help you for so long ;) Try @loopmode's solution above instead. |
I was getting the same errors with Node v10 and NPM v6 in one of my projects. Deleting the node_modules directory and the lock file and then re-installing seems to have resolved the issue. |
Building the project and running tests in node 10 led to the following error: ``` $ npm test > @ test /Users/rzueger/Development/odch/flightbox > gulp test gulp[18899]: ../src/node_contextify.cc:631:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[1]->IsString()' failed. 1: node::Abort() [/usr/local/bin/node] 2: node::Assert(char const* const (*) [4]) [/usr/local/bin/node] 3: node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/bin/node] 4: v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [/usr/local/bin/node] 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<true>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/usr/local/bin/node] 6: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/usr/local/bin/node] 7: 0x1d7692b8427d 8: 0x1d7692b8f755 9: 0x1d7692c0bc20 10: 0x1d7692b944f7 11: 0x1d7692b944f7 12: 0x1d7692b944f7 ``` Fixed by removing package-lock.json and generating a new one (see gulpjs/gulp#2162 (comment)).
Building the project and running tests in node 10 led to the following error: ``` $ npm test > @ test /Users/rzueger/Development/odch/flightbox > gulp test gulp[18899]: ../src/node_contextify.cc:631:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[1]->IsString()' failed. 1: node::Abort() [/usr/local/bin/node] 2: node::Assert(char const* const (*) [4]) [/usr/local/bin/node] 3: node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/bin/node] 4: v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [/usr/local/bin/node] 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<true>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/usr/local/bin/node] 6: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/usr/local/bin/node] 7: 0x1d7692b8427d 8: 0x1d7692b8f755 9: 0x1d7692c0bc20 10: 0x1d7692b944f7 11: 0x1d7692b944f7 12: 0x1d7692b944f7 ``` Fixed by removing package-lock.json and generating a new one (see gulpjs/gulp#2162 (comment)).
Building the project and running tests in node 10 led to the following error: ``` $ npm test > @ test /Users/rzueger/Development/odch/flightbox > gulp test gulp[18899]: ../src/node_contextify.cc:631:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[1]->IsString()' failed. 1: node::Abort() [/usr/local/bin/node] 2: node::Assert(char const* const (*) [4]) [/usr/local/bin/node] 3: node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/bin/node] 4: v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [/usr/local/bin/node] 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<true>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/usr/local/bin/node] 6: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/usr/local/bin/node] 7: 0x1d7692b8427d 8: 0x1d7692b8f755 9: 0x1d7692c0bc20 10: 0x1d7692b944f7 11: 0x1d7692b944f7 12: 0x1d7692b944f7 ``` Fixed by removing package-lock.json and generating a new one (see gulpjs/gulp#2162 (comment)).
For yarn do |
I think we're all understood here - no need to keep posting the same solutions. Update dependencies when you update node. |
I installed Node 10 on MacOS and Win 10. Used it for various node things with no issues. But starting gulp always results in a native crash. Smells like a Node bug but I report it here because I haven't seen it anywhere else.
Same steps for Mac or Win...
gulp
Same result if I run
./node_modules/.bin/gulp
What version of gulp are you using?
What versions of npm and node are you using?
$ gulp -v
[21:10:31] CLI version 3.9.1
[21:10:31] Local version 3.9.1
$ node -v
v10.0.0
If you can't reproduce this, I'm happy to debug more, but since I see it in 2 different environments, hopefully it's easy to reproduce.
The text was updated successfully, but these errors were encountered: