Skip to content
This repository has been archived by the owner on Jun 12, 2018. It is now read-only.

Fix minio PutObject #36

Closed
wants to merge 1 commit into from
Closed

Fix minio PutObject #36

wants to merge 1 commit into from

Conversation

AdallomRoy
Copy link

This commit: minio/minio-go@f98a667 broke rocks-strata (Doesn't compile).
This is a PR to use the new interface.

@AdallomRoy
Copy link
Author

Not sure why this PR fails - it works for me...

@AGFeldman
Copy link
Contributor

AGFeldman commented Oct 9, 2017

Thanks

Not sure why this PR fails - it works for me...

As you mentioned, the change that caused minio to break your build is minio/minio-go@f98a667#diff-178b7853ff9d7acbcc6b327d8723026e, which is from September 19. That change hasn't yet made it into a minio release (https://github.com/minio/minio-go/releases). Maybe Travis CI is using the latest released version of minio while you're using master.

If you don't mind, I'll wait until minio releases the change, then I'll re-run CI and merge.

@thapakazi
Copy link
Contributor

thapakazi commented Nov 27, 2017

@AGFeldman
how long is the ETA for this merge ?
strata doesn't compile any more
screenshot-20171127-13 29 06

My go version is go1.9.2 linux/amd64 with env

go env                                                                                             [
GOARCH="amd64"
GOBIN="~/.go/bin"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="~/.go"
GORACE=""
GOROOT="/usr/lib/go"
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build191252707=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

OR if possible, lets push the builds under release, thanks 🙇‍♂️

@AGFeldman
Copy link
Contributor

Anyone want to update this PR for minio/minio-go#821 ? cc @AdallomRoy

This PR originally addressed minio/minio-go#811, but the API changed again in 821.

All these API changes were released in https://github.com/minio/minio-go/releases/tag/4.0.0

@thapakazi
Copy link
Contributor

Still lot to learn, I am able to get it compiled with these changes, should I create a new PR ?
screenshot-20171128-07 33 40

@AGFeldman
Copy link
Contributor

Thanks all, should be fixed with #37

@AGFeldman AGFeldman closed this Nov 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants