Add PutEncryptedObject and FPutEncryptedObject calls #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api-put-object-encrypted.go
Outdated
| ) | ||
|
|
||
| // PutEncryptedObject - Encrypt and store object. | ||
| func (c Client) PutEncryptedObject(bucketName, objectName string, reader io.Reader, encryptMaterials encrypt.Materials, metadata map[string][]string, progress io.Reader) (n int64, err error) { |
There was a problem hiding this comment.
wait why are we doing it like this?
There was a problem hiding this comment.
I thought we do it like this:
PutEncryptedObject(bucket, object string, r io.Reader, mat encrypt.Materials) (int64,error)
aead
requested changes
Sep 22, 2017
api-put-object-encrypted.go
Outdated
| return 0, err | ||
| } | ||
|
|
||
| m := make(map[string]string) |
api-put-object-file-encrypted.go
Outdated
| ) | ||
|
|
||
| // FPutEncryptedObject - Encrypt and store an object with contents from file at filePath. | ||
| func (c Client) FPutEncryptedObject(bucketName, objectName, filePath, contentType string, encryptMaterials encrypt.Materials) (n int64, err error) { |
api-put-object.go
Outdated
| func (opts PutObjectOptions) validate() (err error) { | ||
| for k := range opts.UserMetadata { | ||
| if isStandardHeader(k) || | ||
| isCSEHeader(k) { |
harshavardhana
requested changes
Sep 22, 2017
| @@ -230,3 +237,15 @@ func isStandardHeader(headerKey string) bool { | |||
| } | |||
| return false | |||
| } | |||
|
|
|||
poornas
force-pushed
the
kfactor2
branch
5 times, most recently
from
3cb393d
to
531f7f2
Compare
harshavardhana
requested changes
Sep 25, 2017
api-put-object.go
Outdated
| @@ -55,7 +55,7 @@ func (opts *PutObjectOptions) getNumThreads() (numThreads int) { | |||
|
|
|||
| // getMetaData - constructs the headers from metadata entered by user in | |||
| // PutObjectOptions struct | |||
| func (opts *PutObjectOptions) getMetadata() (headers http.Header) { | |||
| func (opts PutObjectOptions) getMetadata() (headers http.Header) { | |||
There was a problem hiding this comment.
While we are at it let's rename this function to simply Header() also the returned value is just header not headers
api-put-object.go
Outdated
| @@ -87,6 +87,15 @@ func (opts *PutObjectOptions) getMetadata() (headers http.Header) { | |||
| return | |||
| } | |||
|
|
|||
| func (opts PutObjectOptions) validate() (err error) { | |||
There was a problem hiding this comment.
Add a comment.. and a unit test?
harshavardhana
approved these changes
Sep 26, 2017
aead
approved these changes
Sep 26, 2017
|
Can you squash your changes @poornas ? |
- revive PutEncryptedObject call back, and add a FPutEncryptedObject variant.
|
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #819.
variant. Options struct is now passed in without a pointer.
Leaving the Get calls for @aead.