Add comments

Summary: I tracked down the reason we needed the IPv4 workaround, adding a note to the cabal files. Reviewed By: pepeiborra Differential Revision: D47334685 fbshipit-source-id: e586badc65c92ffa4834a8e117ae05aa7b79e234
facebookincubator · Jul 10, 2023 · 9d839f8 · 9d839f8
1 parent 7d29ebc
commit 9d839f8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/cpp-channel/thrift-cpp-channel.cabal b/cpp-channel/thrift-cpp-channel.cabal
@@ -127,6 +127,8 @@ library
         text-show,
         bytestring
 
+-- Workaround for IPv6 loopback bug on Docker/Ubuntu:
+--   https://github.com/docker/for-linux/issues/1374
 flag tests_use_ipv4
      description: Force tests to use IPV4 whenever bringing thrift clients/servers up
      default: False

diff --git a/http/thrift-http.cabal b/http/thrift-http.cabal
@@ -85,6 +85,8 @@ library
 
   default-language:    Haskell2010
 
+-- Workaround for IPv6 loopback bug on Docker/Ubuntu:
+--   https://github.com/docker/for-linux/issues/1374
 flag tests_use_ipv4
      description: Force tests to use IPV4 whenever bringing thrift clients/servers up
      default: False

diff --git a/server/thrift-server.cabal b/server/thrift-server.cabal
@@ -102,6 +102,8 @@ library
   -- when running hsc2hs on Thrift.Server.ProcessorCallback
   extra-libraries: boost_context
 
+-- Workaround for IPv6 loopback bug on Docker/Ubuntu:
+--   https://github.com/docker/for-linux/issues/1374
 flag tests_use_ipv4
      description: Force tests to use IPV4 whenever bringing thrift clients/servers up
      default: False