Disable signature related functions in scheduled fuzzer runs #9420
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@assignUser The signature change shouldnt fail right since you havent made any signature changes here ? |
|
Ah I see what's happening. I forgot that this job doesn't actually trigger on merge ( |
assignUser
force-pushed
the
no-sigcheck-schedule
branch
from
5535e81
to
df219b8
Compare
|
@assignUser can you fix the conflict ? I will work on merging it. |
assignUser
force-pushed
the
no-sigcheck-schedule
branch
from
dac5d75
to
2168a8e
Compare
|
@kgpai I have rebased and properly fixed the save step, both in this workflow with |
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
|
@assignUser , looks some CI jos are not triggered with latest main branch, https://github.com/facebookincubator/velox/actions/runs/8646131285, can you help check? |
|
@zhli1142015 Sorry for the inconvenience fix is here #9451 |
Thanks |
Summary:
Within `if:`/`${{}}`only single quotes are allowed, due to the fact that broken workflows don't show up in the check suite it got overlooked in #9420
Pull Request resolved: #9451
Reviewed By: bikramSingh91
Differential Revision: D56022463
Pulled By: kgpai
fbshipit-source-id: 79102cc2856db1e18fc4729ee55d602434861e0b
…kincubator#9420) Summary: For the scheduled runs it doesn't make sense to run the signature related steps, specifically generating the signature cache might clobber (through a newer date, not by overwriting) newer stashes on main leading to false positives. This PR also fixes issues with the generation of the baseline signature stash only happening in the scheduled jobs. The fuzzer is now also run on merge (against the parent commit on main) and will stash the signatures afterwards for use in PRs. The signatures stash key was amended with the sha so that we can ensure that the signatures match the merge base of the PR or generate them if they are (not) yet available. Pull Request resolved: facebookincubator#9420 Reviewed By: kagamiori, mbasmanova Differential Revision: D55998367 Pulled By: kgpai fbshipit-source-id: f4198f967de718c2ae1e0029091247c654297315
Summary:
Within `if:`/`${{}}`only single quotes are allowed, due to the fact that broken workflows don't show up in the check suite it got overlooked in facebookincubator#9420
Pull Request resolved: facebookincubator#9451
Reviewed By: bikramSingh91
Differential Revision: D56022463
Pulled By: kgpai
fbshipit-source-id: 79102cc2856db1e18fc4729ee55d602434861e0b
…kincubator#9420) Summary: For the scheduled runs it doesn't make sense to run the signature related steps, specifically generating the signature cache might clobber (through a newer date, not by overwriting) newer stashes on main leading to false positives. This PR also fixes issues with the generation of the baseline signature stash only happening in the scheduled jobs. The fuzzer is now also run on merge (against the parent commit on main) and will stash the signatures afterwards for use in PRs. The signatures stash key was amended with the sha so that we can ensure that the signatures match the merge base of the PR or generate them if they are (not) yet available. Pull Request resolved: facebookincubator#9420 Reviewed By: kagamiori, mbasmanova Differential Revision: D55998367 Pulled By: kgpai fbshipit-source-id: f4198f967de718c2ae1e0029091247c654297315
Summary:
Within `if:`/`${{}}`only single quotes are allowed, due to the fact that broken workflows don't show up in the check suite it got overlooked in facebookincubator#9420
Pull Request resolved: facebookincubator#9451
Reviewed By: bikramSingh91
Differential Revision: D56022463
Pulled By: kgpai
fbshipit-source-id: 79102cc2856db1e18fc4729ee55d602434861e0b
For the scheduled runs it doesn't make sense to run the signature related steps, specifically generating the signature cache might clobber (through a newer date, not by overwriting) newer stashes on main leading to false positives.
This PR also fixes issues with the generation of the baseline signature stash only happening in the scheduled jobs. The fuzzer is now also run on merge (against the parent commit on main) and will stash the signatures afterwards for use in PRs. The signatures stash key was amended with the sha so that we can ensure that the signatures match the merge base of the PR or generate them if they are (not) yet available.