Fix syntax error in workflow yaml #9451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@mbasmanova @kgpai @pedroerp Sorry for the inconvenience. |
kgpai
approved these changes
Apr 11, 2024
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This was referenced Apr 11, 2024
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
yanngyoung
pushed a commit
to yanngyoung/velox
that referenced
this pull request
Apr 12, 2024
Summary:
Within `if:`/`${{}}`only single quotes are allowed, due to the fact that broken workflows don't show up in the check suite it got overlooked in facebookincubator#9420
Pull Request resolved: facebookincubator#9451
Reviewed By: bikramSingh91
Differential Revision: D56022463
Pulled By: kgpai
fbshipit-source-id: 79102cc2856db1e18fc4729ee55d602434861e0b
yanngyoung
pushed a commit
to yanngyoung/velox
that referenced
this pull request
Apr 12, 2024
) Summary: A follow up to facebookincubator#9451 Pull Request resolved: facebookincubator#9454 Reviewed By: bikramSingh91 Differential Revision: D56028187 Pulled By: kgpai fbshipit-source-id: d3b4de36b554b28cf5a42f41f854d05dd7c5f595
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary:
Within `if:`/`${{}}`only single quotes are allowed, due to the fact that broken workflows don't show up in the check suite it got overlooked in facebookincubator#9420
Pull Request resolved: facebookincubator#9451
Reviewed By: bikramSingh91
Differential Revision: D56022463
Pulled By: kgpai
fbshipit-source-id: 79102cc2856db1e18fc4729ee55d602434861e0b
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
) Summary: A follow up to facebookincubator#9451 Pull Request resolved: facebookincubator#9454 Reviewed By: bikramSingh91 Differential Revision: D56028187 Pulled By: kgpai fbshipit-source-id: d3b4de36b554b28cf5a42f41f854d05dd7c5f595
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within
if:/${{}}only single quotes are allowed, due to the fact that broken workflows don't show up in the check suite it got overlooked in #9420