Support ptex mesh - Step 2: fix the shader #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-) fix the winding of triangles in the geometry shader; -) apply correct uv; -) use a more standard way to read data from the buffer texture;
facebook-github-bot
added
the
CLA Signed
|
@ALL: This is ready for review. |
mosra
approved these changes
Sep 6, 2019
msavva
approved these changes
Sep 6, 2019
src/shaders/ptex-default-gl410.geom
Outdated
| @@ -6,8 +6,12 @@ out vec2 uv; | |||
| void main() { | |||
| gl_PrimitiveID = gl_PrimitiveIDIn; | |||
|
|
|||
| uv = vec2(1.0, 0.0); | |||
| gl_Position = gl_in[1].gl_Position; | |||
| // the triangle trip generated is (3, 0, 2, 1), | |||
src/shaders/ptex-default-gl410.geom
Outdated
| uv = vec2(1.0, 0.0); | ||
| gl_Position = gl_in[1].gl_Position; | ||
| // the triangle trip generated is (3, 0, 2, 1), | ||
| // which is is different from replicaSDK. |
eundersander
pushed a commit
to eundersander/habitat-sim
that referenced
this pull request
Aug 6, 2020
…cebookresearch#194) * Changed Shortest Path Follower criteria to use geodesic distance
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
…_fix_shader Support ptex mesh - Step 2: fix the shader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to
-) fix the winding of triangles in the geometry shader;
-) apply correct uv;
-) use a more standard way to read data from the buffer texture;
Motivation and Context
To support ptex mesh rendering in our simulator
How Has This Been Tested
Local on Mac and Linux. See details at #132
Types of changes
Checklist