Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemEff: Set CUDA stream properly #491

Merged
merged 20 commits into from
Nov 10, 2022
Merged

Conversation

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Oct 25, 2022
ghstack-source-id: a386fc94a0e08e532040476248b2a20eef684a89
Pull Request resolved: #491
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 25, 2022
danthe3rd pushed a commit that referenced this pull request Oct 25, 2022
ghstack-source-id: f01ce1f7e4d4b2e85caf17c7a786b0d27dbc8559
Pull Request resolved: #491
@danthe3rd danthe3rd requested a review from fmassa October 25, 2022 12:21
... and add corresponding tests

[ghstack-poisoned]
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups, thanks for fixing this!

danthe3rd added 2 commits October 27, 2022 17:11
... and add corresponding tests

[ghstack-poisoned]
... and add corresponding tests

[ghstack-poisoned]
danthe3rd added 6 commits October 28, 2022 14:43
... and add corresponding tests

[ghstack-poisoned]
... and add corresponding tests

[ghstack-poisoned]
... and add corresponding tests

[ghstack-poisoned]
... and add corresponding tests

[ghstack-poisoned]
... and add corresponding tests

[ghstack-poisoned]
... and add corresponding tests

[ghstack-poisoned]
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Base: 88.33% // Head: 88.33% // No change to project coverage 👍

Coverage data is based on head (88e436b) compared to base (88e436b).
Patch has no changes to coverable lines.

❗ Current head 88e436b differs from pull request most recent head 7933d72. Consider uploading reports for the commit 7933d72 to get more accurate results

Additional details and impacted files
@@                  Coverage Diff                  @@
##           gh/danthe3rd/53/base     #491   +/-   ##
=====================================================
  Coverage                 88.33%   88.33%           
=====================================================
  Files                        80       80           
  Lines                      4802     4802           
=====================================================
  Hits                       4242     4242           
  Misses                      560      560           
Flag Coverage Δ
Python 88.33% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

... and add corresponding tests

[ghstack-poisoned]
danthe3rd added 3 commits November 3, 2022 08:21
... and add corresponding tests

[ghstack-poisoned]
... and add corresponding tests

[ghstack-poisoned]
... and add corresponding tests

[ghstack-poisoned]
... and add corresponding tests

[ghstack-poisoned]
@danthe3rd danthe3rd mentioned this pull request Nov 4, 2022
danthe3rd added 2 commits November 4, 2022 10:04
... and add corresponding tests

[ghstack-poisoned]
... and add corresponding tests

[ghstack-poisoned]
danthe3rd added 2 commits November 7, 2022 13:00
... and add corresponding tests

[ghstack-poisoned]
... and add corresponding tests

[ghstack-poisoned]
@danthe3rd danthe3rd merged commit 7933d72 into gh/danthe3rd/53/base Nov 10, 2022
danthe3rd pushed a commit that referenced this pull request Nov 10, 2022
ghstack-source-id: 890ba685f0c62ea6778c45e2b17713ed92a43080
Pull Request resolved: #491
@danthe3rd danthe3rd deleted the gh/danthe3rd/53/head branch November 10, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants