Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemEff: Raise if wrong bias #510

Merged
merged 4 commits into from
Nov 10, 2022
Merged

Conversation

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2022
danthe3rd pushed a commit that referenced this pull request Nov 4, 2022
ghstack-source-id: 0ed06bd2c98e6d33200426b2985937533a9fb57f
Pull Request resolved: #510
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Base: 88.01% // Head: 87.96% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (0185a34) compared to base (43fa717).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           gh/danthe3rd/62/base     #510      +/-   ##
========================================================
- Coverage                 88.01%   87.96%   -0.05%     
========================================================
  Files                        80       80              
  Lines                      4822     4828       +6     
========================================================
+ Hits                       4244     4247       +3     
- Misses                      578      581       +3     
Flag Coverage Δ
Python 87.96% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xformers/ops/memory_efficient_attention.py 85.20% <50.00%> (-0.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

danthe3rd added 2 commits November 7, 2022 12:42
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danthe3rd danthe3rd merged commit 0185a34 into gh/danthe3rd/62/base Nov 10, 2022
danthe3rd pushed a commit that referenced this pull request Nov 10, 2022
ghstack-source-id: 657076325d46712005afa38e8cce40c6050723a3
Pull Request resolved: #510
@danthe3rd danthe3rd deleted the gh/danthe3rd/62/head branch November 10, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants