Merge pull request #61 from fako1024/60-provide-slimcap_nomock-build-…

…tag-and-allow-feature-toggle

[feature] Support build tag to disable mocks and refactor code

capture/afpacket/afpacket/afpacket.go

@@ -62,7 +62,6 @@ func NewSourceFromLink(link *link.Link, options ...Option) (*Source, error) {
 		snapLen:       DefaultSnapLen,
 		ipLayerOffset: link.Type.IPHeaderOffset(),
 		link:          link,
-		Mutex:         sync.Mutex{},
 	}
 
 	// Apply functional options, if any
@@ -226,10 +225,11 @@ retry:
 
 // Stats returns (and clears) the packet counters of the underlying source
 func (s *Source) Stats() (capture.Stats, error) {
-	s.Lock()
-	defer s.Unlock()
 
+	s.Lock()
 	ss, err := s.eventHandler.GetSocketStats()
+	s.Unlock()
+
 	if err != nil {
 		return capture.Stats{}, err
 	}
@@ -264,11 +264,7 @@ func (s *Source) Close() error {
 		return err
 	}
 
-	if err := s.eventHandler.Fd.Close(); err != nil {
-		return err
-	}
-
-	return nil
+	return s.eventHandler.Fd.Close()
 }
 
 func (s *Source) nextPacketInto(data capture.Packet) (int, error) {
@@ -309,7 +305,7 @@ retry:
 	}
 
 	data[1] = s.ipLayerOffset
-	*(*uint32)(unsafe.Pointer(&data[2])) = uint32(totalLen)
+	*(*uint32)(unsafe.Pointer(&data[2])) = uint32(totalLen) // #nosec: G103
 
 	return n, nil
 }

capture/afpacket/afpacket/afpacket_mock.go

@@ -1,3 +1,6 @@
+//go:build !slimcap_nomock
+// +build !slimcap_nomock
+
 package afpacket
 
 import (
@@ -66,7 +69,7 @@ func (m *MockSource) AddPacketFromSource(src capture.Source) error {
 }
 
 // NewMockSource instantiates a new mock direct AF_PACKET source, wrapping a regular Source
-func NewMockSource(iface string, options ...Option) (*MockSource, error) {
+func NewMockSource(_ string, options ...Option) (*MockSource, error) {
 
 	mockHandler, mockFd, err := event.NewMockHandler()
 	if err != nil {