[feature] Support build tag to disable mocks and refactor code #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fako1024
added
enhancement
2 tasks
els0r
approved these changes
Sep 3, 2023
fako1024
deleted the
60-provide-slimcap_nomock-build-tag-and-allow-feature-toggle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@els0r This solves a conundrum I've been having ever since I added the mock features. The PR looks big, but after all it's just copy / pasting code into new files with & without the new build tag in order to enable / disable it.
This should squeeze out the last bit of performance for package / production builds of goprobe once merged. By default nothing changes, only if the new build tag is set.
Closes #60