-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Fastify 4.23.0 get deprecated "request.routeConfig" warnings #229
Labels
good first issue
Good for newcomers
Comments
Thanks for reporting! |
pgbross
added a commit
to pgbross/fastify-helmet
that referenced
this issue
Sep 12, 2023
pgbross
added a commit
to pgbross/fastify-helmet
that referenced
this issue
Sep 12, 2023
2 tasks
Sure - done in #230 |
kibertoad
pushed a commit
that referenced
this issue
Sep 12, 2023
I didn't work for me at first but trying again with "--save-dev" worked for me. |
This issue is 1yo. Please open a new detailed issue adding a Minimal, Reproducible Example. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Prerequisites
Fastify version
4.23.0
Plugin version
11.0.0
Node.js version
20.3.1
Operating system
Linux
Operating system version (i.e. 20.04, 11.3, 10)
Fedora 39
Description
With Fastify 4.23.0 get
[FSTDEP016] FastifyDeprecation: You are accessing the deprecated "request.routeConfig" property. Use "request.routeOptions.config" instead. Property "req.routeConfig" will be removed in
fastify@5` warnings.This arises in `fastify.addHook('onRequest'...) where it looks for helmet specific config on the route.
Applying the suggested change in the deprecation warning eliminates the warning.
Steps to Reproduce
Simply require the
@fastify/helmet
plugin and observe the server messages in a terminal console.Expected Behavior
No deprecation warnings.
The text was updated successfully, but these errors were encountered: