Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: request route config deprecation - fixes #229 #230

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix: request route config deprecation - fixes #229 #230

merged 1 commit into from
Sep 12, 2023

Conversation

pgbross
Copy link
Contributor

@pgbross pgbross commented Sep 12, 2023

Recent change in Fastify 4.23.0 causes request.routeConfig deprecation warnings.

This PR fixes this by using the recommended request.routeOptions.config property.

Fixes #229 .

Checklist

@pgbross pgbross mentioned this pull request Sep 12, 2023
Closed
2 tasks
gurgunday
gurgunday approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kibertoad kibertoad merged commit d192401 into fastify:master Sep 12, 2023
15 checks passed
@kibertoad
Copy link
Member

thanks!

@gurgunday gurgunday mentioned this pull request Sep 17, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using Fastify 4.23.0 get deprecated "request.routeConfig" warnings
3 participants
@pgbross @kibertoad @gurgunday