Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor refactor #182

Merged
merged 2 commits into from
Aug 3, 2022
Merged

minor refactor #182

merged 2 commits into from
Aug 3, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 3, 2022

disable package-lock generation
move typings to types folder
adapt changes regarding types to package.json
update typing from FastifyPlugin to FastifyPluginCallback

Checklist

Uzlopak added 2 commits August 3, 2022 17:34
move typings to types folder
adapt changes regarding types to package.json
update typing from FastifyPlugin to FastifyPluginCallback
@Uzlopak Uzlopak requested review from Fdawgs and mcollina and removed request for Fdawgs August 3, 2022 15:36
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 3, 2022

Also by setting jobs to 1 the flakyness is finally gone.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 1cd9421 into master Aug 3, 2022
@Fdawgs Fdawgs deleted the minor-refactor branch August 3, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants