Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage #224

Merged
merged 10 commits into from
Jun 30, 2024
Merged

Conversation

jean-michelet
Copy link
Contributor

Related to issue #216

I think an error has been introduced by #182, test.js is not executed since 2022 🥲

I renamed it index.test.js

index.js Outdated Show resolved Hide resolved
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday
Copy link
Member

I’m personally fine with both the ignores and disabling directly

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those branches are just not runnable anymore in the fastify v5 line/with the support matrix we have.

index.js Outdated Show resolved Hide resolved
@mcollina
Copy link
Member

I think you can just remove those lines.

@jean-michelet
Copy link
Contributor Author

Ok, I am working on it

@jean-michelet jean-michelet requested a review from mcollina June 30, 2024 08:13
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a6895d0 into fastify:master Jun 30, 2024
14 checks passed
@Uzlopak
Copy link
Contributor

Uzlopak commented Jul 1, 2024

@jean-michelet
Great job ;).

@jean-michelet
Copy link
Contributor Author

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants