Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branding: Replace all Compute@Edge/C@E references with Compute. #1044

Merged
merged 3 commits into from
Oct 16, 2023
Merged

branding: Replace all Compute@Edge/C@E references with Compute. #1044

merged 3 commits into from
Oct 16, 2023

Conversation

kpfleming
Copy link
Contributor

No description provided.

@kpfleming kpfleming marked this pull request as ready for review October 13, 2023 20:04
@kpfleming
Copy link
Contributor Author

I intentionally left the contents of CHANGELOG.md alone since that is historical information, and I also did not modify the binary files in the testdata directories as I wasn't sure what would be needed to ensure that tests would still pass.

@kpfleming kpfleming requested a review from Integralist October 13, 2023 20:19
@Integralist
Copy link
Collaborator

The CI is failing because gosec released a new version today that no longer respects the #nosec directive. It's a simple fix so I can sort that out on Monday.

@Integralist Integralist mentioned this pull request Oct 16, 2023
Merged
Integralist
Integralist approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one suggested edit.

pkg/commands/logtail/root.go Outdated Show resolved Hide resolved
@kpfleming @Integralist
Update pkg/commands/logtail/root.go
f882a21 
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
@Integralist Integralist added the documentation Improvements or additions to documentation label Oct 16, 2023
@Integralist Integralist merged commit b4ccd9e into fastly:main Oct 16, 2023
6 checks passed
@kpfleming kpfleming deleted the compute-branding branch October 16, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Integralist Integralist Integralist approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpfleming @Integralist