Add support for TLS client and batch size options for splunk #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellymclaughlin
force-pushed
the
splunk-tls-updates
branch
from
133064e to
fa16169
Compare
Integralist
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
@kellymclaughlin this LGTM but before merging could you first rebase master.
Depending on when you see this notification you might need to wait until I've gotten someone to approve this PR (which will cut a new 'patch' CLI release v0.21.2).
Once that's done and you've rebased, then your PR can be cut as a 'minor' release v0.22.0.
Thanks!
|
@kellymclaughlin just to confirm the 0.21.2 CLI release has now been cut, so if you could rebase master before merging please. Thanks 🙂 |
kellymclaughlin
force-pushed
the
splunk-tls-updates
branch
from
fa16169 to
697e758
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows from this go-fastly PR.