Add support for TLS client and batch size options for splunk #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the tls_client_cert, tls_client_key, request_max_entries, and request_max_bytes configuration options for the splunk logging endpoint.
|
Thanks for the PR! There's a couple of other PRs from you that I need to catch back up on (since I've been on paternity leave), so those will take priority for me today. Hopefully I can find some time later today to review this PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the
tls_client_cert,tls_client_key,request_max_entries, andrequest_max_bytesconfiguration options for the splunk logging endpoint.