Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go-fastly to v7 #707

Merged
merged 18 commits into from
Nov 19, 2022
Merged

Bump go-fastly to v7 #707

merged 18 commits into from
Nov 19, 2022

Conversation

grantstephens
Copy link
Contributor

@grantstephens grantstephens commented Nov 14, 2022 •
edited by Integralist
Loading

This got a bit complicated as Kingpin doesn't like pointers, which is what go-fastly v7 introduced.

NOTE: An important change within this PR is not presuming we know how the API works. The go-fastly API client has taken this approach by not trying to validate certain fields that it thinks the API will need. The CLI will now take a similar approach where it will only provide the fields that go-fastly says are 'required' because the code base shouldn't introduce code logic that could become stale if the API ever changes its behaviours.

@grantstephens grantstephens force-pushed the grantstephens/go-fastly-v7 branch 2 times, most recently from 03943db to b454eae Compare November 15, 2022 17:30
@grantstephens grantstephens changed the title Change to v7 everywhere Bump go-fastly to v7 Nov 15, 2022
@grantstephens grantstephens marked this pull request as ready for review November 15, 2022 17:32
Integralist
Integralist requested changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks @grantstephens for taking the time to work on this. There's a lot of nice but subtle clean-up improvements made in here that I really like.

I have a couple of comments/requests. Take a look through and either amend or let me know your thoughts. Thanks!

pkg/commands/backend/backend_test.go Outdated Show resolved Hide resolved
pkg/commands/backend/create.go Outdated Show resolved Hide resolved
pkg/commands/dictionary/dictionary_test.go Outdated Show resolved Hide resolved
pkg/commands/domain/create.go Show resolved Hide resolved
pkg/commands/domain/create.go Outdated Show resolved Hide resolved
pkg/commands/logging/bigquery/bigquery_test.go Outdated Show resolved Hide resolved
pkg/commands/logging/bigquery/create.go Outdated Show resolved Hide resolved
Integralist
Integralist approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but otherwise approving.

pkg/commands/backend/create.go Outdated Show resolved Hide resolved
@grantstephens grantstephens force-pushed the grantstephens/go-fastly-v7 branch from 56ccc2a to 64246ba Compare November 18, 2022 10:25
@grantstephens grantstephens force-pushed the grantstephens/go-fastly-v7 branch from cbe12ee to d6bbb6b Compare November 18, 2022 15:06
Integralist
Integralist approved these changes Nov 19, 2022
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @grantstephens ❤️

@Integralist Integralist merged commit c9419a7 into main Nov 19, 2022
@Integralist Integralist deleted the grantstephens/go-fastly-v7 branch November 19, 2022 19:18
@Integralist Integralist added the dependencies Pull requests that update a dependency file label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Integralist Integralist Integralist approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grantstephens @Integralist