-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the documentation into separate pages #202
Conversation
Break up the usage documentation into separate pages: basic usage (Training your Pooch with some elements removed), single file downloads, downloaders, processors, and advanced tricks. Moved the processor and downloader specifications from the docstring of Pooch.fetch to the respective pages and link to them from the docstrings. Also did general updates to the docstrings (for example, to include the new retrieve function) and tutorials. Separated the side menu into Getting Started, User Guide, and Reference Documentation like in all other projects.
It would be great to get a couple of eyes on this before proceeding. What do you think of the new layout? |
This looks great, thanks Leo! |
Add an intermediate level tutorial
Just had a cursory check, but looks good! By the way, it's now possible to enable Read the Docs to autobuild for PRs. See: |
Move things between them so that the beginner tutorial is really minimal
Start with retrieve and include links to setting up Pooch through the beginner tutorial
Thanks for the comments @danshapero and @hugovk. I didn't RTD was doing that now but it looks pretty cool! Might give it a shot. I made a few more tweaks and divided the Training your Pooch tutorial into 3 sections: beginner, intermediate, and advanced. I made the I'll give this some time for other to see and comment. I'm pretty happy with the layout and will stop messing around with it now (sorry). |
I don't think that the The most basic feature of pooch (to me) is to download a single file using
That is: I use Here is another simple example showing how to use ftp and then unzip the file:
And here is an example where you decompress a gzip file before saving it.
So, my point is: These three examples show everything that I (a beginner) needed to know to create the pyshtools datasets module. If these examples were on page 1 ("start here"), I wouldn't need to read any further. In my opinion "beginner" means download a single file, and "intermediate" means deal with more than 1 file and registries. |
@MarkWieczorek thanks for the inputs! I agree that the first example should be downloading a single file with
Those examples for
Fair point. Got lost in the puns on that one 🙂
Right after the code sample there is: The GOODBOY returned by pooch.create is an instance of the Pooch class, which handles downloading files from the registry using the fetch method. See the documentation for pooch.create and pooch.Pooch for more options. But I agree that this could be a lot clearer. I'll make a note about expanding the current "Retrieving a data file" page to include more advanced things like FTP downloads and unzipping. But those could be added later since this PR is already quite big. |
Added some docs explaining what the return of create is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great to me! I like how the tutorials are split by levels.
I think we can safely merge this. If anyone finds any typo or something that should be fixed or improved, we can do that on a future PR. |
Break up the usage documentation into separate pages: basic usage
(Training your Pooch with some elements removed), single file downloads,
downloaders, processors, and advanced tricks. Moved the processor and
downloader specifications from the docstring of Pooch.fetch to the
respective pages and link to them from the docstrings. Also did general
updates to the docstrings (for example, to include the new retrieve
function) and tutorials. Separated the side menu into Getting Started,
User Guide, and Reference Documentation like in all other projects.
Fixes #188
See a rendered version of the docs here: https://www.leouieda.com/pooch-docs-refactor/
Reminders:
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
and the base__init__.py
file for the package.AUTHORS.md
file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.