Append nanoseconds to dataset name in test_historical_retrival to prevent tests stomping over each other #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ival to prevent tests stomping over each other Signed-off-by: Achal Shah <achals@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1593 +/- ##
==========================================
- Coverage 83.60% 77.38% -6.23%
==========================================
Files 65 64 -1
Lines 5758 5633 -125
==========================================
- Hits 4814 4359 -455
- Misses 944 1274 +330
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <achals@gmail.com>
woop
reviewed
May 28, 2021
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
woop
reviewed
May 28, 2021
woop
changed the title
Signed-off-by: Achal Shah <achals@gmail.com>
achals
force-pushed
the
flaky-integration-tests
branch
from
926d314
to
afe0a38
Compare
woop
approved these changes
May 28, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
woop
pushed a commit
that referenced
this pull request
Jun 7, 2021
…vent tests stomping over each other (#1593) * Append the python version to the dataset name in test_historical_retrival to prevent tests stomping over each other Signed-off-by: Achal Shah <achals@gmail.com> * make format Signed-off-by: Achal Shah <achals@gmail.com> * use version_info to avoid mucking wiht strings Signed-off-by: Achal Shah <achals@gmail.com> * time_ns followed by randint Signed-off-by: Achal Shah <achals@gmail.com> * fix lint Signed-off-by: Achal Shah <achals@gmail.com> * Use 1000-9999 for fixed width Signed-off-by: Achal Shah <achals@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
Becuase of the way we construct same dataset name in test_historical_retrival, when running a matrix test there's the possiblity of two different tests constructing the same dataset name, and hence stomping over each other.
This PR adds the python version to the name of the dataset - this should be sufficient since the test matrix tests different python versions. An alternative would be to use the github action run id, but that ties the test a little bit closer to github than seems necessary.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: