Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current directory in sys path for CLI commands that might depend on custom providers #1594

Conversation

MattDelac
Copy link
Collaborator

What this PR does / why we need it:
Only feast apply works with custom providers. Other CLI commands that depend on the provider don't work with custom ones.
This is because the current directory is append to the SYS PATH only during feast apply

Which issue(s) this PR fixes:

Fixes #1589

Does this PR introduce a user-facing change?:

Append current directory in sys path for all CLI commands that depend on a provider

@feast-ci-bot
Copy link
Collaborator

Hi @MattDelac. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #1594 (bcd0e65) into master (62f826b) will decrease coverage by 0.03%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1594      +/-   ##
==========================================
- Coverage   83.59%   83.55%   -0.04%     
==========================================
  Files          65       65              
  Lines        5755     5760       +5     
==========================================
+ Hits         4811     4813       +2     
- Misses        944      947       +3     
Flag Coverage Δ
integrationtests 83.48% <20.00%> (-0.06%) ⬇️
unittests 77.34% <20.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_operations.py 32.16% <ø> (+0.16%) ⬆️
sdk/python/feast/cli.py 45.27% <20.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62f826b...bcd0e65. Read the comment docs.

@MattDelac MattDelac force-pushed the fix_cli_materialize_with_custom_provider branch from 80539d7 to bcd0e65 Compare May 28, 2021 13:40
@woop
Copy link
Member

woop commented May 28, 2021

/ok-to-test

@woop
Copy link
Member

woop commented May 28, 2021

/kind bug

@woop
Copy link
Member

woop commented May 28, 2021

@MattDelac btw there is a fix for the flaky test over here #1593

@woop
Copy link
Member

woop commented May 28, 2021

@MattDelac I think it may be possible to just use https://github.com/feast-dev/feast/pull/1594/files#diff-cc33a5e7afa90467a37c11f60b2a380bd86af97524300ca6484a0373e2f00cb6R70 so that we don't need to append in multiple places. Also, I think we need to support remote repos using the -c flag, right?

@MattDelac MattDelac force-pushed the fix_cli_materialize_with_custom_provider branch from bcd0e65 to 35917dd Compare June 1, 2021 13:54
@MattDelac
Copy link
Collaborator Author

I think it may be possible to just use https://github.com/feast-dev/feast/pull/1594/files#diff-cc33a5e7afa90467a37c11f60b2a380bd86af97524300ca6484a0373e2f00cb6R70 so that we don't need to append in multiple places.

Yes I put it in cli_check_repo() that is called by all CLI commands

Also, I think we need to support remote repos using the -c flag, right?

Sounds like out of topic and related to #1556 no ? Unsure I understand your point here

@MattDelac MattDelac force-pushed the fix_cli_materialize_with_custom_provider branch from 35917dd to 201d676 Compare June 1, 2021 13:57
Signed-off-by: Matt Delacour <matt.delacour@shopify.com>
@MattDelac MattDelac force-pushed the fix_cli_materialize_with_custom_provider branch from 201d676 to 76bff49 Compare June 1, 2021 14:05
@MattDelac
Copy link
Collaborator Author

@woop This PR is ready for a final review

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MattDelac, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jun 1, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit 6edf195 into feast-dev:master Jun 1, 2021
woop pushed a commit that referenced this pull request Jun 7, 2021
Signed-off-by: Matt Delacour <matt.delacour@shopify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI feast materialize does not work with custom providers
4 participants