Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with lint test and upgrade pip version #1964

Merged
merged 3 commits into from
Oct 22, 2021

Conversation

felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Oct 22, 2021

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: This PR fixes the issues with the lint test. Specifically, it seems like this was the issue. It also upgrades the pip version to be >=21.3.1.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021

Codecov Report

Merging #1964 (36a9703) into master (ec4c02b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1964   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files          99       99           
  Lines        7922     7922           
=======================================
  Hits         6494     6494           
  Misses       1428     1428           
Flag Coverage Δ
integrationtests 73.85% <100.00%> (-0.44%) ⬇️
unittests 59.51% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/gcp.py 87.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4c02b...36a9703. Read the comment docs.

@felixwang9817 felixwang9817 changed the title [WIP] Test potential fix for linter Fix issues with lint test Oct 22, 2021
@felixwang9817
Copy link
Collaborator Author

/kind bug

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817 felixwang9817 changed the title Fix issues with lint test Fix issues with lint test and update pip version Oct 22, 2021
@felixwang9817 felixwang9817 changed the title Fix issues with lint test and update pip version Fix issues with lint test and set pip version Oct 22, 2021
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

.github/workflows/integration_tests.yml Outdated Show resolved Hide resolved
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Oct 22, 2021
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@felixwang9817 felixwang9817 changed the title Fix issues with lint test and set pip version Fix issues with lint test and upgrade pip version Oct 22, 2021
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this pr inspire of failing builds because the pr is meant to fix the builds, but won't reflect in the pr_integration_tests github actions because of it using pull_request_target.

@achals achals merged commit 3b5ea8f into feast-dev:master Oct 22, 2021
@felixwang9817 felixwang9817 deleted the fix_linter branch October 22, 2021 18:35
@felixwang9817 felixwang9817 restored the fix_linter branch October 23, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants