Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with lint test and upgrade pip version #1964

Merged
merged 3 commits into from
Oct 22, 2021
Merged

Fix issues with lint test and upgrade pip version #1964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a909ee0
Test potential fix for linter
felixwang9817 Oct 22, 2021
36a45ca
Downgrade pip to <21.3 to ensure integration tests pass
felixwang9817 Oct 22, 2021
36a9703
Upgrade pip version to >=21.3.1 to fix issues with pip==21.3.0
felixwang9817 Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ jobs:
aws-region: us-west-2
- name: Use AWS CLI
run: aws sts get-caller-identity
- name: Upgrade pip version
run: |
pip install --upgrade "pip>=21.3.1"
- name: Get pip cache dir
id: pip-cache
run: |
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ jobs:
with:
python-version: "3.7"
architecture: x64
- name: Upgrade pip version
run: |
pip install --upgrade "pip>=21.3.1"
- name: Get pip cache dir
id: pip-cache
run: |
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/pr_integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ jobs:
aws-region: us-west-2
- name: Use AWS CLI
run: aws sts get-caller-identity
- name: Upgrade pip version
run: |
pip install --upgrade "pip>=21.3.1"
- name: Get pip cache dir
id: pip-cache
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ jobs:
with:
python-version: ${{ matrix.python-version }}
architecture: x64
- name: Downgrade pip
- name: Upgrade pip version
run: |
pip install --upgrade "pip<21.3"
pip install --upgrade "pip>=21.3.1"
- name: Get pip cache dir
id: pip-cache
run: |
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/gcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class GCSRegistryStore(RegistryStore):
def __init__(self, registry_config: RegistryConfig, repo_path: Path):
uri = registry_config.path
try:
from google.cloud import storage
import google.cloud.storage as storage
except ImportError as e:
from feast.errors import FeastExtrasDependencyImportError

Expand All @@ -34,7 +34,7 @@ def __init__(self, registry_config: RegistryConfig, repo_path: Path):
self._blob = self._uri.path.lstrip("/")

def get_registry_proto(self):
from google.cloud import storage
import google.cloud.storage as storage
from google.cloud.exceptions import NotFound

file_obj = TemporaryFile()
Expand Down