Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unexpected feature view deletion when applying edited odfv #2054

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Fix unexpected feature view deletion when applying edited odfv #2054

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5084ef2
Delete feature-view proto from correct container when an on-demand-fe…
ArrichM Nov 17, 2021
6f63453
Add test case in test_registry.py to check if regular feature views a…
ArrichM Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ def apply_feature_view(
):
return
else:
del self.cached_registry_proto.feature_views[idx]
del existing_feature_views_of_same_type[idx]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - do you mind adding a test in test_registry.py for this case? I definitely feel like we should have caught this bug

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I just added a case testing the modification of an odfv.

break

existing_feature_views_of_same_type.append(feature_view_proto)
Expand Down