-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Feature/adding remote online store #4226
Merged
franciscojavierarceo
merged 3 commits into
feast-dev:master
from
lokeshrangineni:feature/adding-remote-onlinestore-rebase
Jun 14, 2024
Merged
feat: Feature/adding remote online store #4226
franciscojavierarceo
merged 3 commits into
feast-dev:master
from
lokeshrangineni:feature/adding-remote-onlinestore-rebase
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc: @tokoko @dmartinol |
lokeshrangineni
changed the title
Feature/adding remote onlinestore rebase
[WIP] -[DRAFT] Feature/adding remote onlinestore rebase
May 24, 2024
lokeshrangineni
changed the title
[WIP] -[DRAFT] Feature/adding remote onlinestore rebase
[WIP] -[DRAFT] Feature/adding remote online store
May 24, 2024
tokoko
reviewed
May 24, 2024
sdk/python/tests/integration/feature_repos/universal/online_store/remote.py
Outdated
Show resolved
Hide resolved
tokoko
reviewed
May 24, 2024
sdk/python/tests/integration/feature_repos/repo_configuration.py
Outdated
Show resolved
Hide resolved
tokoko
reviewed
May 24, 2024
tokoko
reviewed
May 24, 2024
lokeshrangineni
changed the title
[WIP] -[DRAFT] Feature/adding remote online store
feat: Feature/adding remote online store
Jun 3, 2024
lokeshrangineni
force-pushed
the
feature/adding-remote-onlinestore-rebase
branch
5 times, most recently
from
June 3, 2024 18:37
5508d31
to
d5b27c6
Compare
lokeshrangineni
force-pushed
the
feature/adding-remote-onlinestore-rebase
branch
from
June 6, 2024 16:43
78a9020
to
720b6e0
Compare
dmartinol
reviewed
Jun 11, 2024
dmartinol
reviewed
Jun 11, 2024
dmartinol
reviewed
Jun 11, 2024
dmartinol
reviewed
Jun 11, 2024
dmartinol
reviewed
Jun 11, 2024
dmartinol
reviewed
Jun 11, 2024
dmartinol
reviewed
Jun 11, 2024
sdk/python/tests/integration/feature_repos/repo_configuration.py
Outdated
Show resolved
Hide resolved
lokeshrangineni
force-pushed
the
feature/adding-remote-onlinestore-rebase
branch
from
June 12, 2024 15:43
7e324ae
to
d895fdc
Compare
lokeshrangineni
requested review from
whoahbot and
sfc-gh-madkins
as code owners
June 12, 2024 15:46
lokeshrangineni
requested review from
sudohainguyen,
niklasvm,
kevjumba,
yelo-blood and
a team
as code owners
June 12, 2024 15:46
lokeshrangineni
force-pushed
the
feature/adding-remote-onlinestore-rebase
branch
from
June 12, 2024 19:47
1a7e4db
to
5231bac
Compare
dmartinol
reviewed
Jun 13, 2024
dmartinol
reviewed
Jun 13, 2024
dmartinol
reviewed
Jun 13, 2024
dmartinol
reviewed
Jun 13, 2024
dmartinol
reviewed
Jun 13, 2024
sdk/python/tests/integration/online_store/test_remote_online_store.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm minor comments
tokoko
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
lokeshrangineni
force-pushed
the
feature/adding-remote-onlinestore-rebase
branch
from
June 13, 2024 23:36
b1a1535
to
f2079fb
Compare
Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
…rebase' into feature/adding-remote-onlinestore-rebase
franciscojavierarceo
approved these changes
Jun 14, 2024
franciscojavierarceo
pushed a commit
that referenced
this pull request
Jun 18, 2024
# [0.39.0](v0.38.0...v0.39.0) (2024-06-18) ### Bug Fixes * Feast UI importlib change ([#4248](#4248)) ([5d486b8](5d486b8)) * Feature server no_feature_log argument error ([#4255](#4255)) ([15524ce](15524ce)) * Feature UI Server image won't start in an OpenShift cluster ([#4250](#4250)) ([4891f76](4891f76)) * Handles null values in data during GO Feature retrieval ([#4274](#4274)) ([c491e57](c491e57)) * Make Java gRPC client use timeouts as expected ([#4237](#4237)) ([f5a37c1](f5a37c1)) * Remove self assignment code line. ([#4238](#4238)) ([e514f66](e514f66)) * Set default values for feature_store.serve() function ([#4225](#4225)) ([fa74438](fa74438)) ### Features * Add online_read_async for dynamodb ([#4244](#4244)) ([b5ef384](b5ef384)) * Add the ability to list objects by `tags` ([#4246](#4246)) ([fbf92da](fbf92da)) * Added deadline to gRPC Java client ([#4217](#4217)) ([ff429c9](ff429c9)) * Adding vector search for sqlite ([#4176](#4176)) ([2478831](2478831)) * Change get_online_features signature, move online retrieval functions to utils ([#4278](#4278)) ([7287662](7287662)) * Feature/adding remote online store ([#4226](#4226)) ([9454d7c](9454d7c)) * List all feature views ([#4256](#4256)) ([36a574d](36a574d)) * Make RegistryServer writable ([#4231](#4231)) ([79e1143](79e1143)) * Remote offline Store ([#4262](#4262)) ([28a3d24](28a3d24)) * Set optional full-scan for deletion ([#4189](#4189)) ([b9cadd5](b9cadd5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the new online store of type "remote" which will interact with remote feature server. Able to read and write the features only at the moment.
Which issue(s) this PR fixes:
#4121