-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remote offline Store #4262
feat: Remote offline Store #4262
Conversation
ddbc10a
to
7f64708
Compare
…ight server and client Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
…ed _make_flight_info Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
… an environment variable Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> Signed-off-by: Abdul Hameed <ahameed@redhat.com>
use feature_view_names to transfer feature views and remove dummies Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
…ight server and client Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
…), offline, ui and registry Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
2eb38d1
to
2818626
Compare
@redhatHameed just curious, are the tests failing only in gh workflows? Do they pass locally? |
Maybe it's too early to kickoff a thread, but in that case, shouldn't we have a separate materialization server with its own codebase? (if you have an issue we can move the discussion there) |
maybe, that would certainly be a cleaner approach, but imho wouldn't really serve any other practical purpose. I'll open a ticket and we probably should pick this up later once remote offline is a bit more fleshed out. |
@tokoko Yes, apart some of them that fail locally. Do you have any idea why from the GH action execution we don't even see the log of the |
I don't have any privileges there. @franciscojavierarceo @jeremyary any ideas? |
sdk/python/tests/integration/feature_repos/universal/data_sources/file.py
Outdated
Show resolved
Hide resolved
Yes it does - apart from the one test case -> t |
sdk/python/tests/integration/feature_repos/universal/data_sources/file.py
Outdated
Show resolved
Hide resolved
2e1879a
to
08c2616
Compare
sdk/python/feast/offline_server.py
Outdated
del self.flights[key] | ||
return fl.RecordBatchStream(table) | ||
|
||
def offline_write_batch(self, command, key): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not a mandatory to give the types, but it makes it more readable to have types unless it is expected to have any data type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lokeshrangineni
You mean in the methods parameters or the return value or both?
I guess you mean for all the methods and not only this specific one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was specifically about method parameters. but if there is no change in functionality better to add types to return variable also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lokeshrangineni the change implemented under commit thanks @tmihalac addressing it
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
08c2616
to
dec05c9
Compare
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
update the document change and fix teardown function
@jeremyary any thoughts I am getting incorrect credentials error one of integration test it was running fine previously |
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
@redhatHameed It's a rate limit error, says |
Implemented PR change proposal
@tokoko can we get your approval on this if no more comments. Also who will approve this for merging ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, lgtm. great work, guys. @jeremyary or @franciscojavierarceo can approve and merge
# [0.39.0](v0.38.0...v0.39.0) (2024-06-18) ### Bug Fixes * Feast UI importlib change ([#4248](#4248)) ([5d486b8](5d486b8)) * Feature server no_feature_log argument error ([#4255](#4255)) ([15524ce](15524ce)) * Feature UI Server image won't start in an OpenShift cluster ([#4250](#4250)) ([4891f76](4891f76)) * Handles null values in data during GO Feature retrieval ([#4274](#4274)) ([c491e57](c491e57)) * Make Java gRPC client use timeouts as expected ([#4237](#4237)) ([f5a37c1](f5a37c1)) * Remove self assignment code line. ([#4238](#4238)) ([e514f66](e514f66)) * Set default values for feature_store.serve() function ([#4225](#4225)) ([fa74438](fa74438)) ### Features * Add online_read_async for dynamodb ([#4244](#4244)) ([b5ef384](b5ef384)) * Add the ability to list objects by `tags` ([#4246](#4246)) ([fbf92da](fbf92da)) * Added deadline to gRPC Java client ([#4217](#4217)) ([ff429c9](ff429c9)) * Adding vector search for sqlite ([#4176](#4176)) ([2478831](2478831)) * Change get_online_features signature, move online retrieval functions to utils ([#4278](#4278)) ([7287662](7287662)) * Feature/adding remote online store ([#4226](#4226)) ([9454d7c](9454d7c)) * List all feature views ([#4256](#4256)) ([36a574d](36a574d)) * Make RegistryServer writable ([#4231](#4231)) ([79e1143](79e1143)) * Remote offline Store ([#4262](#4262)) ([28a3d24](28a3d24)) * Set optional full-scan for deletion ([#4189](#4189)) ([b9cadd5](b9cadd5))
What this PR does / why we need it:
This PR added feature for remote offline store contain below changes.
Added an Offline Server using Arrow Flight:
feast serve_offline
command.Added an Offline Remote Client:
Updated Helm Chart for Deploying as a service on Kubernetes:
feast_mode
property based on the deployment choice user can set the property. The online mode is the default and maintains backward compatibility with previous Feast Feature Server implementations.Helm install examples:
Added documentation for remote offline support
Added example for remote offline
Which issue(s) this PR fixes:
Fixes #4032
Fixes