-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python SDK so FeatureSet can import Schema from Tensorflow metadata #450
Update Python SDK so FeatureSet can import Schema from Tensorflow metadata #450
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Other than the above, it looks good as a first cut. |
/hold |
7966a5d
to
9a1f24a
Compare
/hold cancel |
@davidheryanto this PR contains the same code as #449 |
Yes because the end to end tests were written in Python and it depends on the Python SDK, |
9439ea1
to
ffc26fc
Compare
- Update Field, Feature and Entity class with fields from presence_constraints, shape_type and domain_info
- Update documentation for properties in Field - Deduplication refactoring in FeatureSet
They are not necessary for now and to avoid unexpected breaking changes.
In import_tfx_schema method, the domain info is first made inline so there is no need to have schema level domain info when updating Feast Entity and Feature. Also added documentation to setter property methods in Field.py
283d52d
to
6af74c6
Compare
/lgtm |
What this PR does / why we need it:
This PR extends
FeatureSet
,Entity
andFeature
class in Python SDK so they can contain constraints defined in theSchema
from Tensorflow metadata:https://github.com/tensorflow/metadata/blob/ddf582f66eeeddb862de6d53c3e03d6eed1c04a6/tensorflow_metadata/proto/v0/schema.proto
These contraints
presence_constraints
,shape_type
anddomain_info
can be used for validation of feature values and presence in Feast. Typical usage when one is already using Tensorflow data validation is as follows:Which issue(s) this PR fixes:
Related to #172
Does this PR introduce a user-facing change?: