Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python SDK so FeatureSet can import Schema from Tensorflow metadata #450

Merged
merged 12 commits into from
Apr 10, 2020
Merged

Update Python SDK so FeatureSet can import Schema from Tensorflow metadata #450

merged 12 commits into from
Apr 10, 2020

Commits on Apr 10, 2020

  1. Add skeleton for update/get schema in FeatureSet

    @davidheryanto
    davidheryanto authored and zhilingc committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    bfd8682 View commit details
    Browse the repository at this point in the history

  2. Add update_schema method to FeatureSet 

    - Update Field, Feature and Entity class with fields from presence_constraints, shape_type and domain_info
    @davidheryanto
    davidheryanto authored and zhilingc committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    756533e View commit details
    Browse the repository at this point in the history

  3. Update error message when domain ref is missing from top level schema

    @davidheryanto
    davidheryanto authored and zhilingc committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    9abd082 View commit details
    Browse the repository at this point in the history

  4. Add more assertion in test_update_schema before updating schema

    @davidheryanto
    davidheryanto authored and zhilingc committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    b2b7783 View commit details
    Browse the repository at this point in the history

  5. Fix conflicting versions in package requirements

    @davidheryanto
    davidheryanto authored and zhilingc committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    4574f72 View commit details
    Browse the repository at this point in the history

  6. Add export_schema method to export schema from FeatureSet

    @davidheryanto
    davidheryanto authored and zhilingc committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    5029550 View commit details
    Browse the repository at this point in the history

  7. Add exporting of Tensorflow metadata schema from FeatureSet. 

    - Update documentation for properties in Field
- Deduplication refactoring in FeatureSet
    @davidheryanto
    davidheryanto authored and zhilingc committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    dc39ca7 View commit details
    Browse the repository at this point in the history

  8. Remove changes to mypy generated codes

    @davidheryanto
    davidheryanto authored and zhilingc committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    57dfa02 View commit details
    Browse the repository at this point in the history

  9. Revert changes to packages version in requirements-ci and setup.py 

    They are not necessary for now and to avoid unexpected breaking changes.
    @davidheryanto
    davidheryanto authored and zhilingc committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    bfd282d View commit details
    Browse the repository at this point in the history

  10. Remove 'schema' param in 'from_proto' method in Entity and Feature. 

    In import_tfx_schema method, the domain info is first made inline so there is no need to have schema level domain info when updating Feast Entity and Feature.

Also added documentation to setter property methods in Field.py
    @davidheryanto
    davidheryanto authored and zhilingc committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    dcd6e19 View commit details
    Browse the repository at this point in the history

  11. Fix rebase errors, apply black

    zhilingc committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    6af74c6 View commit details
    Browse the repository at this point in the history

  12. Remove unnecessary imports

    zhilingc committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    d12aead View commit details
    Browse the repository at this point in the history