Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty array when retrieving stats data #930

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

terryyylim
Copy link
Member

What this PR does / why we need it:
These 2 methods, this and that will always be returning at least an empty arraylist. So essentially, when being called in getFeatureStatistics, these conditions, this and that will never be triggered, since length of arraylist will always at least be 1.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

N/A

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terryyylim, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Aug 5, 2020

/lgtm

@terryyylim
Copy link
Member Author

/test test-end-to-end-redis-cluster

1 similar comment
@terryyylim
Copy link
Member Author

/test test-end-to-end-redis-cluster

@terryyylim
Copy link
Member Author

/test test-end-to-end-batch-dataflow

@feast-ci-bot feast-ci-bot merged commit be0d54a into feast-dev:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants