Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty array when retrieving stats data #930

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Fix empty array when retrieving stats data #930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions core/src/main/java/feast/core/service/StatsService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ public GetFeatureStatisticsResponse getFeatureStatistics(GetFeatureStatisticsReq
List<FeatureNameStatistics> featureNameStatistics =
getFeatureNameStatisticsByDate(
statisticsRetriever, featureSet, features, timestamp, request.getForceRefresh());
if (featureNameStatistics.size() != 0) {
featureNameStatisticsList.add(featureNameStatistics);
woop marked this conversation as resolved.
Show resolved Hide resolved
}
featureNameStatisticsList.add(featureNameStatistics);
timestamp += 86400; // advance by a day
}
Expand All @@ -147,14 +150,16 @@ public GetFeatureStatisticsResponse getFeatureStatistics(GetFeatureStatisticsReq
List<FeatureNameStatistics> featureNameStatistics =
getFeatureNameStatisticsByDataset(
statisticsRetriever, featureSet, features, datasetId, request.getForceRefresh());
featureNameStatisticsList.add(featureNameStatistics);
if (featureNameStatisticsList.size() == 0) {
throw new RetrievalException(
String.format(
"Unable to find any data over provided data sets %s",
request.getIngestionIdsList()));
if (featureNameStatistics.size() != 0) {
featureNameStatisticsList.add(featureNameStatistics);
}
}
if (featureNameStatisticsList.size() == 0) {
throw new RetrievalException(
String.format(
"Unable to find any data over provided data sets %s",
request.getIngestionIdsList()));
}
}

// Merge statistics values across days/datasets
Expand Down