Fix build on macOS Catalina

[ghost]

This PR fixes #159, as the problem seems to be related to the change of the default shell from bash to zsh in Catalina.

[benesch]

Hey, thanks for the PR. I'm a bit confused though, because the error message in the issue you filed (#159) doesn't line up with your fix here. Based on the output there, configure ran successfully, since stdout starts with "Configuring librdkafka" and ends with "Now type 'make' to build". Also, the backtrace starts in "build_script_build::make_librdkafka":

rust-rdkafka/rdkafka-sys/build.rs

Line 125 in caa1d92

run_command_or_fail("librdkafka", "make", &["-j", &num_cpus::get().to_string(), "libs"]);

Is it possible that you didn't have make installed?

[ghost]

@benesch Thank you for quick reply.

The error is still related to ./configure because

Running command: "./configure --disable-sasl --disable-ssl --disable-lz4" in dir: librdkafka

is the last logged item and also because the stack trace contains line 112, which is the one fixed in this PR:

   0: std::panicking::default_hook::{{closure}}
   1: std::panicking::default_hook
   2: <std::panicking::begin_panic::PanicPayload<A> as core::panic::BoxMeUp>::get
   3: std::panicking::continue_panic_fmt
   4: std::thread::local::fast::Key<T>::try_initialize
   5: build_script_build::run_command_or_fail
             at ./build.rs:25
   6: build_script_build::build_librdkafka
             at ./build.rs:112

Basically, the problem is that although ./configure does all the configuration, for some reason it returns non-zero exit code. It returns 0 as the exit code if invoked from shell manually or from Rust as sh -c ./configure, and this PR uses the latter approach as a workaround.

As a reference, levedb-sys crate had similar issue, which was fixed in a similar way: skade/leveldb-sys#11.

[benesch]

Hmm, thanks for the additional reference point. I’m still worried there’s something deeper afoot. The leveldb issue you filed also shows configure running, but make failing (because it didn’t know how to make the distclean target). I’ll upgrade my Mac to Catalina and see if I can reproduce.

…

On Mon, Oct 21, 2019 at 8:55 AM Alexander Rodin ***@***.***> wrote: @benesch <https://github.com/benesch> Thank you for quick reply. The error is still related to ./configure because Running command: "./configure --disable-sasl --disable-ssl --disable-lz4" in dir: librdkafka is the last logged item and also because the stack trace contains line 112, which is the one fixed in this PR: 0: std::panicking::default_hook::{{closure}} 1: std::panicking::default_hook 2: <std::panicking::begin_panic::PanicPayload<A> as core::panic::BoxMeUp>::get 3: std::panicking::continue_panic_fmt 4: std::thread::local::fast::Key<T>::try_initialize 5: build_script_build::run_command_or_fail at ./build.rs:25 6: build_script_build::build_librdkafka at ./build.rs:112 As a reference, levedb-sys crate had similar issue, which was fixed in a similar way: skade/leveldb-sys#11 <skade/leveldb-sys#11>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#160?email_source=notifications&email_token=AAGXSIGK6TD22PLSF7OF6R3QPWRCXA5CNFSM4JC4OJ6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB2G4QQ#issuecomment-544501314>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGXSIBNLIGTFHRA4J4BT7DQPWRCXANCNFSM4JC4OJ6A> .

[benesch]

Ok, this reproduced instantly. Thanks again for the report. I dug in pretty deep, and came to the conclusion that while the proposed fix here does fix the issue, it obscures the real issue, which is that using relative paths with std::process::Command::current_dir is documented to be broken, and is particularly broken on macOS Catalina: rust-lang/rust#37868 (comment)

I submitted #161, which more clearly works around the problem, IMO. Let me know what you think!

[ghost]

I like #161, I think it solves the problem in a cleaner way. Closing this one.