Avoid use of undefined std::process::Command behavior #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
pushed a commit
to vectordotdev/rust-rdkafka
that referenced
this pull request
Oct 22, 2019
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
This was referenced Oct 22, 2019
std::process::Command is known to be unpredictable when a relative path is used together with `current_dir`, and outright fails on macOS Catalina [0]. Absolutize paths before passing them to std::process::Command to stay within the documented constraints of the API. [0]: rust-lang/rust#37868
benesch
force-pushed
the
catalina-build
branch
from
07980ed
to
7f0bf05
Compare
This was referenced Oct 22, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::process::Command is known to be unpredictable when a relative path
is used together with
current_dir, and outright fails on macOSCatalina 0. Absolutize paths before passing them to
std::process::Command to stay within the documented constraints of the
API.
Supersedes #160.