Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile enhancement to make it AL9-compatible #466

Closed
shreyb opened this issue Aug 8, 2023 · 0 comments · Fixed by #479
Closed

Makefile enhancement to make it AL9-compatible #466

shreyb opened this issue Aug 8, 2023 · 0 comments · Fixed by #479
Assignees
Labels
enhancement New feature or request future Feature requests we will not address now, but at some point in the future.
Milestone

Comments

@shreyb
Copy link
Collaborator

shreyb commented Aug 8, 2023

Add a:

OSR=$(shell /bin/sh -c ' . /etc/os-release; echo $$VERSION_ID | sed -e s/\..*//')

and some:

ifeq ($OSR,7) ... endif

Originally posted by @marcmengel in #464 (review)

This is to make sure we don't try to build the Tracing RPM on AL9 when we run make.

@shreyb shreyb added enhancement New feature or request future Feature requests we will not address now, but at some point in the future. labels Aug 8, 2023
@marcmengel marcmengel self-assigned this Sep 28, 2023
marcmengel added a commit that referenced this issue Sep 28, 2023
@marcmengel marcmengel mentioned this issue Sep 28, 2023
@marcmengel marcmengel linked a pull request Sep 28, 2023 that will close this issue
@shreyb shreyb added this to the 1.5 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future Feature requests we will not address now, but at some point in the future.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants