Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #479

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Bug fixes #479

merged 4 commits into from
Sep 29, 2023

Conversation

marcmengel
Copy link
Contributor

Fixes for #477 #476 #473 #466 #460 #458, and for swallowing stderr of condor_submit.

@marcmengel
Copy link
Contributor Author

Tests are clean now.

Copy link
Collaborator

@shreyb shreyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, except for the config submodule bit. Thanks for fixing all of these!

config Outdated Show resolved Hide resolved
templates/simple/simple.cmd Show resolved Hide resolved
@marcmengel
Copy link
Contributor Author

I will note that the swallowing of condor_submit's stderr outupt was probably the cause of several tickets, where we got failures with no other error message visible -- condor_submit said something on stderr, and we threw it away 👎

@shreyb
Copy link
Collaborator

shreyb commented Sep 29, 2023

Oh REALLY.... that's good to know.

@shreyb shreyb merged commit b5945d2 into master Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment