Fix GH-17 variables do not get expanded #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These point to the solution: * https://forum.serverless.com/t/serverless-plugin-resolving-variable-references/2233/2 * https://github.com/serverless/serverless/pull/3911/files TL;DR: dschep wrote "Serverless changed it’s behavior a few releases ago. That variable substitution is not called by the time plugin constructors get called. Unless you actually need it then, just access it in your lifecycle hooks, it’ should be resolved by then."
|
@shentonfreude Awesome job. I'm going to spend some time trying to look at this and a few other PRs for an upcoming release. Thanks for your work! |
|
@shentonfreude tested this fix. Works well and should make it into the next release. |
|
Thanks again @shentonfreude. Great catch and thanks for the fix. Included in the most recent version - should be building and publishing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These point to the solution:
TL;DR: dschep wrote "Serverless changed it’s behavior a few releases
ago. That variable substitution is not called by the time plugin
constructors get called. Unless you actually need it then, just access
it in your lifecycle hooks, it’ should be resolved by then."