Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of files as --file argument #8

Closed
wants to merge 2 commits into from

Conversation

Akababa
Copy link

@Akababa Akababa commented Oct 14, 2017

It works but is probably missing all the edge cases due to my mindless copy-pasting. It would be nice to integrate git diff somehow but probably not worth the headache.

@fernando-mc
Copy link
Owner

@Akababa I pushed a new version with some new functionality tonight - I'll be looking at how I can resolve the conflicts given those changes but I'd like to get this in too.

@fernando-mc fernando-mc self-assigned this Oct 22, 2017
@Akababa
Copy link
Author

Akababa commented Nov 2, 2017

Awesome! I've been using this on my own for a while now but it feels nice to have my first open source contribution.

@fernando-mc
Copy link
Owner

@Akababa I'm putting this back on my agenda for the next release. Sorry about the delay here.

@fernando-mc
Copy link
Owner

After a bit more review I think this may be impacted by the changes to #18

Can you pull the latest version and toss these changes in again? I'd like to include this.

@fernando-mc fernando-mc assigned Akababa and unassigned fernando-mc Feb 12, 2018
@amsross
Copy link
Contributor

amsross commented Feb 28, 2018

@Akababa Is it possible to take a second look at the existing _uploadDirectory and _uploadFiles methods and where they are called in order to use more of the existing code path? It looks to me that this functionality could be achievable further down the call chain with a good bit less (duplicate) logic.

@fernando-mc
Copy link
Owner

Leaving this open for now, but it will need to be updated to reflect recent changes and conform to style checks.

@linusmarco
Copy link
Contributor

@Akababa, if you have any questions or need any help merging the recent linting/docs changes into this PR, just let me know.

@fernando-mc
Copy link
Owner

Closing for now. We can revisit in the future if conflicts are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants