Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Playoff Series and fixe for all-star logos #30

Merged
merged 25 commits into from
Feb 8, 2022

Conversation

dannoh
Copy link
Contributor

@dannoh dannoh commented Feb 5, 2022

image

This addresses issue #6

@fewieden
Copy link
Owner

fewieden commented Feb 6, 2022

@dannoh thank you for your contribution and sorry that your previous MR was dangling for so long without attention.

I commented on your changes, let me know if you need help on some of them.

@fewieden
Copy link
Owner

fewieden commented Feb 6, 2022

Can you move your added screenshots from the images directory to .github where the current images are stored? You probably also want to add the screenshot from the PR description.

Then you can reference them in the README file

MMM-NHL.js Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
templates/MMM-NHL.njk Outdated Show resolved Hide resolved
templates/MMM-NHL.njk Outdated Show resolved Hide resolved
templates/MMM-NHL.njk Outdated Show resolved Hide resolved
node_helper.js Outdated Show resolved Hide resolved
node_helper.js Show resolved Hide resolved
node_helper.js Outdated Show resolved Hide resolved
@fewieden fewieden merged commit 8689e0b into fewieden:develop Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants