Fix playoff series display in new API #55
Conversation
This playoff endpoint data was pulled from https://github.com/Zmalski/NHL-API-Reference?tab=readme-ov-file#playoff-information
|
This gets the display from having no Series info to, e.g.:
|
Updates changelog I didn't make any changes to the functions that the linter was complaining about, so I just made some token comments to make it happy.
I was comparing against the wrong variable as well as not correctly handling the transition from one round to the next.
|
I have this PR running and it is working as expected with the playoffs. |
The new NHL API returns the current round as, for example, 3 even when all series from round 2 haven't been completed. This adds detection of series which haven't been played all the way out and sets that as the current round.
|
I am maintaining https://github.com/parnic/MMM-NHL for now until @fewieden makes his return :). I will be keeping that master branch updated for this season. |
Nice! Thank you! 🚀 I have changed the URL for the module to your fork in the official module list so that other users can benefit from your changes. As soon as you no longer maintain your fork, we can of course change it back again. Please activate the issues tab in your fork. |
Done. |
This playoff endpoint data was pulled from https://github.com/Zmalski/NHL-API-Reference?tab=readme-ov-file#playoff-information