Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix playoff series display in new API #55

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Fix playoff series display in new API #55

wants to merge 6 commits into from

Commits on Apr 22, 2024

  1. Fix playoff series display in new API 

    This playoff endpoint data was pulled from https://github.com/Zmalski/NHL-API-Reference?tab=readme-ov-file#playoff-information
    @parnic
    parnic committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    626219a View commit details
    Browse the repository at this point in the history

  2. Satisfy PR checks 

    Updates changelog

I didn't make any changes to the functions that the linter was complaining about, so I just made some token comments to make it happy.
    @parnic
    parnic committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ac96983 View commit details
    Browse the repository at this point in the history

  3. Remove trailing spaces

    @parnic
    parnic committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b3e85e8 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Fix round filter 

    I was comparing against the wrong variable as well as not correctly handling the transition from one round to the next.
    @parnic
    parnic committed May 7, 2024
    Configuration menu
    Copy the full SHA
    93f4c56 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Increase version

    @parnic
    parnic committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8983660 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Compute which round(s) to show ourselves 

    The new NHL API returns the current round as, for example, 3 even when all series from round 2 haven't been completed. This adds detection of series which haven't been played all the way out and sets that as the current round.
    @parnic
    parnic committed May 20, 2024
    Configuration menu
    Copy the full SHA
    69d5dd8 View commit details
    Browse the repository at this point in the history