Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Daemon Custom IPNI Endpoint Flag #409

Closed
jtsmedley opened this issue Sep 7, 2023 · 0 comments · Fixed by #410
Closed

HTTP Daemon Custom IPNI Endpoint Flag #409

jtsmedley opened this issue Sep 7, 2023 · 0 comments · Fixed by #410

Comments

@jtsmedley
Copy link
Contributor

We currently have no flag to set a custom endpoint for IPNI lookups when launched with lassie daemon. This flag is essential to be able to run Lassie with it's own indexstar endpoint and is a flag already when using lassie fetch --ipni-endpoint https://cid.contact (https://github.com/filecoin-project/lassie/blob/main/cmd/lassie/fetch.go#L65).

jtsmedley added a commit to jtsmedley/lassie that referenced this issue Sep 7, 2023
Closes filecoin-project#409 by adding the IPNI Endpoint Flag to the Daemon and adds a positive/negative test for the flag on the daemon.

Adding the positive/negative test required changing the exit command on 119 of daemon.go to pass the err on up.  Please review and confirm this won't introduce any unintentional side effects.
@rvagg rvagg closed this as completed in #410 Sep 7, 2023
rvagg pushed a commit that referenced this issue Sep 7, 2023
Closes #409 by adding the IPNI Endpoint Flag to the Daemon and adds a positive/negative test for the flag on the daemon.

Adding the positive/negative test required changing the exit command on 119 of daemon.go to pass the err on up.  Please review and confirm this won't introduce any unintentional side effects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant