Add IPNI Endpoint Flag to Daemon #410
Merged
+33
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes filecoin-project#409 by adding the IPNI Endpoint Flag to the Daemon and adds a positive/negative test for the flag on the daemon. Adding the positive/negative test required changing the exit command on 119 of daemon.go to pass the err on up. Please review and confirm this won't introduce any unintentional side effects.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
==========================================
+ Coverage 77.27% 77.38% +0.11%
==========================================
Files 87 87
Lines 6701 6700 -1
==========================================
+ Hits 5178 5185 +7
+ Misses 1257 1248 -9
- Partials 266 267 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #409 by adding the IPNI Endpoint Flag to the Daemon and adds a positive/negative test for the flag on the daemon.
Adding the positive/negative test required changing the exit command on 119 of daemon.go to pass the err on up. Please review and confirm this won't introduce any unintentional side effects.