Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving GC Followup #6905

Merged
merged 8 commits into from
Jul 29, 2021
Merged

Moving GC Followup #6905

merged 8 commits into from
Jul 29, 2021

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Jul 28, 2021

Follow up from #6854

This improves code readability with better variable names.
It also fixes a (minor) bug, whereby we always create absolute symlinks even though the link might be in the same directory

@vyzo vyzo added team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs epic/splitstore labels Jul 28, 2021
@vyzo vyzo requested a review from Stebalien July 28, 2021 08:58
@vyzo vyzo requested a review from a team as a code owner July 28, 2021 08:58
@vyzo vyzo mentioned this pull request Jul 28, 2021
Co-authored-by: Jakub Sztandera <kubuxu@protocol.ai>
blockstore/badger/blockstore.go Outdated Show resolved Hide resolved
@vyzo vyzo enabled auto-merge July 29, 2021 05:36
@jennijuju jennijuju added this to the 1.11.1 milestone Jul 29, 2021
@jennijuju jennijuju added P2 P2: Should be resolved release/backport labels Jul 29, 2021
@jennijuju
Copy link
Member

This should be backported to release/v1.11.1

@vyzo vyzo merged commit 2fd12da into master Jul 29, 2021
@vyzo vyzo deleted the fix/moving-gc-followup branch July 29, 2021 05:54
@jennijuju jennijuju mentioned this pull request Aug 13, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 P2: Should be resolved team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants