Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some flags like -fPIC may not be passed to C/C++ code by default anymore with the Swift 6 SDK bundle #195

Open
finagolfin opened this issue Nov 12, 2024 · 3 comments
Open

Some flags like -fPIC may not be passed to C/C++ code by default anymore with the Swift 6 SDK bundle #195

finagolfin opened this issue Nov 12, 2024 · 3 comments

Comments

@finagolfin
Copy link
Owner

I will look into adding this back by default, but in the meantime, such flags can be manually added back on the command-line by adding something like -Xcc -fPIC.
@lhoward
Copy link

lhoward commented Nov 12, 2024

Thanks for this! No longer an issue here as I removed the dependency but I'm sure it'll come back to bite me again.

marcprux added a commit to skiptools/skip-bridge that referenced this issue Dec 1, 2024
@marcprux
Add -fPIC compiler argument when building (works around finagolfin/sw…
9856e47 
…ift-android-sdk#195)
@marcprux
Copy link
Contributor

Do we think this might make it in for the 6.0.3 SDK release? I'd be happy to submit a PR for it myself, but I don't want to collide with #193.

@finagolfin
Copy link
Owner Author

I'll definitely fix this for the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lhoward @marcprux @finagolfin